Update content of "Sparrow Crashes" messages. #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto jmh_messages
…nto jmh_messages
…nto jmh_messages
If you use Filebeat as a log aggregator, the messages are not divided by fields. Added a set of filters for Elasticsearch so that a log message is split up into separate fields.
anmekin
reviewed
Feb 1, 2018
| @@ -32,5 +32,8 @@ deploy/settings.yml | |||
| deploy/google/app.yaml | |||
| !deploy/google/app.yaml.example | |||
|
|
|||
| # Virtual environment | |||
| venv/ | |||
There was a problem hiding this comment.
Please add these changes to your local .gitignore file. They shouldn't be in .gitignore.
anmekin
reviewed
Feb 1, 2018
omaha_server/crash/senders.py
Outdated
| logger = logging.getLogger('crashes') | ||
|
|
||
| extra.update(tags) | ||
| extra['sparrow_version'] = tags['ver'] if 'ver' in tags else 'unknown' |
There was a problem hiding this comment.
Please rename sparrow_version to app_version.
anmekin
reviewed
Feb 1, 2018
omaha_server/crash/senders.py
Outdated
| extra['logger_name'] = 'omaha_server' | ||
|
|
||
| # Send message with logger. | ||
| logger.info(add_extra_to_log_message("Sparrow Crashes", extra=extra)) |
There was a problem hiding this comment.
Please use an environment variable to set app specific crash message(e.g. Sparrow crashes).
|
Could you please squash your changes in 1-2 commits? |
anmekin
reviewed
Feb 1, 2018
| @@ -1,5 +1,5 @@ | |||
| [bumpversion] | |||
| current_version = 0.6.3 | |||
| current_version = 0.6.3.1 | |||
There was a problem hiding this comment.
Please don't change the version. We bump it when preparing a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.