Speed up /admin statistics page "Requests & Events" #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are millions of requests in the database, this page took tens of seconds to load. The reason was an unnecessary .distinct(...) call on a QuerySet. This commit removes this call.
|
Would also appreciate at least a cursory comment on this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are millions of requests in the database, this page took tens of seconds to load. In extreme situations, it could even DoS the database, and thus kill the server.
The reason was an unnecessary
.distinct()call on the QuerySet that contains theAppRequests. The call was unnecessary because Django automatically fetches theidfor eachAppRequest. Every row thus had a uniqueid, and was thus necessarily distinct from all the others. This PR removes the.distinct()call, which leads to a very significant performance improvement.