Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform_svg is neat - contribute upstream? Also, try from_graph? #3

Open
mohawk2 opened this issue Nov 5, 2020 · 1 comment
Open

Comments

@mohawk2
Copy link

mohawk2 commented Nov 5, 2020

I was just looking at reverse-deps for GraphViz2 and saw your transform_svg API, which looks quite neat and not very specific to your module. Are you open to me pulling that into GraphViz2 proper (crediting you, obviously)?

Are you aware of the brand-new https://metacpan.org/pod/GraphViz2#from_graph method? It would allow you to construct a https://metacpan.org/pod/Graph object from your underlying data (possibly with an as_graph method/lazy-built attribute), and then you could have a graphvizify function underlying your existing graph method. See https://metacpan.org/pod/GraphViz2::Parse::STT for inspiration if interested - if you're a bit busy but interested, I'll be happy to submit a PR :-)

@Csson
Copy link
Owner

Csson commented Dec 29, 2020

Hi! Of course, feel free to pluck it if you want 🙂

I have noticed that things have been changing in GraphViz2, so I should probably try to get up to speed. Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants