-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/635 #764
base: dev
Are you sure you want to change the base?
Feature/635 #764
Conversation
Added burning_glass to cu_js_includes_enabled in .install Added burning_glass to array in .module file at cu_js_includes_block_options() Added cu_js_includes_burning_glass_form() in .forms.inc file Added view burning_glass js includes to cu_js_includes_secure_permissions() in .permissions.inc file Added to cu_js_includes_get_include_types() in .types.inc file Added Add Burning GLass Include to [types] array in cu_js_includes_express_node_list_groups() in .types.inc file Added burning glass php template in /templates/burning_glass.php
- change name of template file's extension to .tpl.php - remove a line of code created for debugging purposes
Last time I had mentioned this to Jo she had some concerns with this content and the direction of the academic program pages, etc. We should loop her in on this before we merge it. |
@kevincrafts Ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This includes add the JS snippet to pages as specified. The snippets do not interfere with any other include that has also been added to the page.
- making sure the access_code and program_code in the burning_glass.tpl.php are output as strings - fixing bad reference to form fields in cu_js_includes.forms.inc -> cu_js_includes_burning_glass_form()
Jo has reached out to Catherine Horning on this request - hopefully we'll get some clarification soon. |
Adding Burning Glass JS include:
work steps to add this feature: