Skip to content

Commit

Permalink
offer the prepare callback for non-exception messages. this change is…
Browse files Browse the repository at this point in the history
… backwards-incompatible. change 'prepareException' to 'prepareMessage' to support this change.
  • Loading branch information
Daniel Gross committed Nov 10, 2012
1 parent 7554f75 commit 1c85a2f
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions python/logging/greplin/gec/logHandler.py
Expand Up @@ -28,12 +28,12 @@ class GecHandler(logging.Handler):
"""Log observer that writes exceptions to json files to be picked up by upload.py.""" """Log observer that writes exceptions to json files to be picked up by upload.py."""




def __init__(self, path, project, environment, serverName, prepareException=None): def __init__(self, path, project, environment, serverName, prepareMessage=None):
self.__path = path self.__path = path
self.__project = project self.__project = project
self.__environment = environment self.__environment = environment
self.__serverName = serverName self.__serverName = serverName
self.__prepareException = prepareException self.__prepareMessage = prepareMessage
logging.Handler.__init__(self) logging.Handler.__init__(self)




Expand Down Expand Up @@ -68,11 +68,14 @@ def formatLogMessage(self, item):
except TypeError: except TypeError:
itemMessage = 'Error formatting message' itemMessage = 'Error formatting message'


return { log = {
'type': "%s message" % item.levelname, 'type': "%s message" % item.levelname,
'message': itemMessage, 'message': itemMessage,
'backtrace': "%s:%d at %s" % (item.module, item.lineno, item.pathname) 'backtrace': "%s:%d at %s" % (item.module, item.lineno, item.pathname)
} }
if self.__prepareMessage:
return self.__prepareMessage(log)
return log




def formatException(self, item): def formatException(self, item):
Expand All @@ -83,8 +86,8 @@ def formatException(self, item):
'logMessage': getattr(item, 'message', None) or getattr(item, 'msg', None), 'logMessage': getattr(item, 'message', None) or getattr(item, 'msg', None),
'backtrace': item.exc_text 'backtrace': item.exc_text
} }
if self.__prepareException: if self.__prepareMessage:
return self.__prepareException(exception) return self.__prepareMessage(exception)
return exception return exception




Expand Down

0 comments on commit 1c85a2f

Please sign in to comment.