In-app icons missing

[videosmith]

Bug Description
Prompt mode button missing decoration

Steps to Reproduce

1. Run qprompt-v1.0-2c9752c-v1.0-linux-64-gcc.AppImage
2. Enter full screen mode
3. Click 'Start Prompter'

Expected behavior
Buttons should display properly

Screenshots (optional)

Device information

• QPrompt Version: qprompt-v1.0-2c9752c-v1.0-linux-64-gcc
• Operating System: Debian 11 (Bullseye) latest updates, Dell Inspiron 15 (2x Pentium 3237U @ 1.90GHz), Intel HD Graphics 2500

[Cuperino]

Seems like the ability to incorporate icons from the system's theme is either broken or the icons being requested are not part of any of the active icon themes.
When you look at QPrompt's top menu bar and left menus, do you see any icons or no icons at all? (Icons from the editor toolbar don't count, those always ship with QPrompt.)

[videosmith]

[Cuperino]

Thank you! All icons are missing. I will look into this.

[Cuperino]

Quick update: QPrompt is reading system icons correctly, but installing the missing icons doesn't solve this issue because changes to the system theme's icons are not being reflected inside of QPrompt. I don't know if this is a problem with AppImage containerization, a problem with the Gnome desktop environment, or a problem with KDE's icons framework. The first two seem more likely.

Because your setups are usually single purpose, I will suggest installing a distribution with a desktop environment based on the Qt toolkit, such as LXQt and KDE Plasma; both usually come with breeze-icons pre-installed, which is the icons set used by QPrompt. Debian 11 is one of such distributions, all you must do is select KDE Plasma Desktop instead of Gnome Desktop Environment during installation. Also, both Plasma and LXQt offer better performance than Gnome.

I intend to respect system icon preferences on Linux distributions, but not fully if it means QPrompt's most essential icons will go missing. What I will do is replace the most essential icons with copies that are to be included within QPrompt.

[videosmith]

Was using Debian 11.3's LXQt, switched to KDE... icons are back, thank you.

[Cuperino]

Interesting... I will look into LXQt, maybe I'm wrong about them using the same icon set... Maybe they use different icons in Debian LXQt than Lubuntu 22.04, or maybe there lies a clue into why icons aren't working.

[Cuperino]

Forced use of internal copy of the breeze-icons used for QPrompt's main actions: toggle, increase, reduce. All other icons will continue to be missing on distros that do not provide them, but at least the two icons used for these 3 actions will show. This way system icon themes can continue to be respected.

I did not force the inclusion of all themes because the approach I use on Windows and macOS fails on Linux, and the alternate approach being used here automatically limits our ability to dynamically pick different icons based on factors like screen resolution and up-scaling.

Closing issue for now.

[Cuperino]

New beta and release candidate is out. This issue should be fixed.
https://github.com/Cuperino/QPrompt/releases/tag/v1.1.0-rc-1

[videosmith]

Thank you. On Wednesday, July 27, 2022 at 11:34:32 PM EDT, Javier O. Cordero Pérez ***@***.***> wrote: New beta and release candidate is out. This issue should be fixed. https://github.com/Cuperino/QPrompt/releases/tag/v1.1.0-rc-1 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[videosmith]

fyi: Prompt controls at bottom of FullScreen mode still missing decorations. Left side menu displays correctly.

qprompt-v1.1.3-aa79ad5-linux-gcc-x86_64.AppImage

Displays correctly in current Arm build and these previous:
qprompt-main-0fbee21-linux-64-clang.AppImage
qprompt-v1.1-8fc947c-linux-64-clang.AppImage
qprompt-v1.1.1-a873a2e-linux-64-clang.AppImage

[videosmith]

qprompt-v1.1.3-aa79ad5-linux-gcc-x86_64.deb build displays buttons in full screen mode, however with different buttons than the AppImage builds.

Also some apparently inactive buttons at the top of the main editor window.

[Cuperino]

The problem lies either with the AppImage format itself or with the way that KDE builds them. Either way, those icons are taken from the system and I have no way of overriding most on the AppImage, because they're invoked by the Kirigami framework and not QPrompt.

[videosmith]

Understood not an issue. Any thoughts on the two dark "buttons' in the second image near the cursor?

[Cuperino]

It seems like the system theme is overriding those buttons as well, which would be the appropriate behavior if the icon being provided by the system could be illustrated correctly. Why are the system icons looking circular is the true mystery...

• There could be something wrong with the SVG library supplied with this version of QPrompt. The SVG library is provided by the Qt framework, which received a bug fixes update. I personally doubt this is the case, because it would affect other plataforms.
• It most likely is a problem with the AppImage container (this throws back to my previous reply), which may be returning incorrect data from the system. This kind of issue is more common than you would expect, and can happen with every secure universal package out there. Some formats, such as Snaps, use a copy of the system theme, provided exclusively for use in Snaps, which often cannot be switched along with the system theme. I personally don't know where in the system an AppImage gets its system icons from.

Since I have full control over those icons (because they're invoked from QPrompt), I could have QPrompt stop trying to use the icons for those buttons, which should resolve the issue for all the buttons that are fully visible in those three pictures, minus the Back button.

Let's re-open this bug so that I don't forget to do this... The main difference from the existing solution is that those icons won't continue to be respected if provided by the system, and instead QPrompt's icons (they're actually KDE Icons) will be used for those buttons.

[Cuperino]

I was making the change to test it later with an AppImage when I realized the button at the button of the About Page should be visible as it is for it does not request from the system theme. This means the problem you see in v1.1.3 has nothing to do with where the icons are being sourced from. Since the same AppImage is showing icons correctly in other systems, I suspect the issue may be specific to AppImages in Debian or to what I mentioned two replies ago.

I'll make the change either way, just to be extra certain.

[Cuperino]

The change I made didn't fix this issue of the missing icons, right?

[videosmith]

Still issues in Fullscreen mode with deb arm64 install.

[Cuperino]

That matches my experiences from yesterday on the RPi 3B+ running Debian 11 Bullseye (Qt 5.15.2, KF5 5.78.0).

What about the AppImage?

[videosmith]

On x86 or arm64

[Cuperino]

x86_64, because AppImage continues to be unsupported on arm64 due to lack of support for the architecture by KDE Craft, the build system we're using.