Added support for client side certificate validation #8
Conversation
|
@Hakky54 That's awesome! Thanks for doing this. |
|
I just added a unit test to check if loading the sslcontext and executing a http request is working correctly. Please let me know what you thoughts are |
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.junit.Assert.assertThat; | ||
|
|
||
| public class NetworkCallTest { |
There was a problem hiding this comment.
Would you mind writing this in kotlin.
you can add kotlin support for test folder as well in gradle
There was a problem hiding this comment.
Sure, just changed it to kotlin.
But what do you mean exactly with:
you can add kotlin support for test folder as well in gradle
There was a problem hiding this comment.
Thanks a lot.
I thought kotlin dependency is not added for the test folder 🤦 .
but it already there, sorry my bad ✋.
|
Thanks for your contribution. |
|
It was my pleasure to contribute back 😊 |
This PR is an implementation for the issue mentioned here: Feature Support for SSLContext
These code changes will enable users of asynkio to provide a custom ssl configuration by supplying a preconfigured SSLContext instance. That will provide the underlying client the options to validate the server certificate against your own list of trusted certificates. Besides validating the server certificate it also will have the support for mutual authentication.