Merge pull request #1770 from PatrickvL/fix_memleak_pointsprite_textures

Avoid memory leak in point-sprite texture swaps
Cxbx-Reloaded · Nov 7, 2019 · 97b13c3 · 97b13c3
2 parents d50cc9c + 9aea685
commit 97b13c3
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/core/hle/D3D8/Direct3D9/TextureStates.cpp b/src/core/hle/D3D8/Direct3D9/TextureStates.cpp
@@ -260,6 +260,10 @@ void XboxTextureStateConverter::Apply()
         g_pD3DDevice->GetTexture(3, &pTexture);
         g_pD3DDevice->SetTexture(0, pTexture);
 
+        // Avoid a dangling reference that would lead to a memory leak
+        if (pTexture != nullptr)
+            pTexture->Release();
+
         // disable all other stages
         g_pD3DDevice->SetTextureStageState(1, D3DTSS_COLOROP, D3DTOP_DISABLE);
         g_pD3DDevice->SetTextureStageState(1, D3DTSS_ALPHAOP, D3DTOP_DISABLE);