Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLE NV2A: AMD Instability #1294

Closed
PatrickvL opened this issue Jun 17, 2018 · 3 comments
Closed

LLE NV2A: AMD Instability #1294

PatrickvL opened this issue Jun 17, 2018 · 3 comments
Labels
enhancement general improvement of the emu graphics GPU and/or game graphics related LLE Low Level Emulation

Comments

@PatrickvL
Copy link
Member

PatrickvL commented Jun 17, 2018

It's suspected that OpenGL drivers for AMD GPU's are crash prone when calls are made from more than one thread.

To solve this, we could refactor our LLE nv2a pgraph renderer such, that all OpenGL calls are made through the command queue handling thread.

Any OpenGL calls not currently done from that thread (like initialization and Xbox to host framebuffer copies) can be moved to emulator-specific commands, one for each call or set of calls.

@PatrickvL PatrickvL added enhancement general improvement of the emu graphics GPU and/or game graphics related LLE Low Level Emulation labels Jun 17, 2018
@PatrickvL PatrickvL changed the title LLE nv2a: move all opengl calls to one thread LLE nv2a: move all OpenGL calls to one thread Jun 17, 2018
@JayFoxRox
Copy link
Contributor

It's suspected that OpenGL drivers for AMD GPU's are crash prone when calls are made from more than one thread.

This would break a ton of programs and definitely isn't the case.

I'd suspect that the GL context is not transferred correctly (which may or may not be an upstream issue in XQEMU already) between threads though. That's the only logical explanation I can come up with.

@Sarkie
Copy link

Sarkie commented Jul 1, 2018

Probably best to create a small test case to prove the issue?

@LukeUsher LukeUsher changed the title LLE nv2a: move all OpenGL calls to one thread LLE NV2A: AMD Instability Jul 23, 2018
@PatrickvL
Copy link
Member Author

Since we no longer support LLE GPU, this issue does no longer apply. Closing as "won't do".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement general improvement of the emu graphics GPU and/or game graphics related LLE Low Level Emulation
Projects
None yet
Development

No branches or pull requests

3 participants