Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore file in git action dart format #182

Closed
guyluz11 opened this issue Sep 30, 2022 · 8 comments · Fixed by #202
Closed

Ignore file in git action dart format #182

guyluz11 opened this issue Sep 30, 2022 · 8 comments · Fixed by #202
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept for hacktoberfest

Comments

@guyluz11
Copy link
Member

guyluz11 commented Sep 30, 2022 •
edited

As you can see the git action format did a format on lib/injection.config.dart
b66e3c1

injection.config.dart is autogenerated file and thus should not get formatted.

Please change git action dart format so that it will ignore lib/injection.config.dart

cbj_hub/.github/workflows/format.yml

Line 29 in 4e84eca

run: find . -name "*.dart" ! -path '*/gen/*' | tr '\n' ' ' | xargs dart format

Should become

find . -name "*.dart" ! -path '*/gen/*' ! -name 'injection.config.dart' | tr '\n' ' ' | xargs dart format
@guyluz11 guyluz11 added enhancement New feature or request good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ labels Sep 30, 2022
@guyluz11 guyluz11 changed the title Remove injection.config.dart from dart format Ignore file in git action dart format Sep 30, 2022
@drishtigehi
Copy link

Hi, I would like to work on this issue, kindly assign it to me

@guyluz11
Copy link
Member Author

It is now yours @drishtigehi

@bilal-aamer
Copy link

Hey @guyluz11, Could you assign this issue to me as well. Thanks

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 4, 2022

This issue already assigned to someone else

Hey @guyluz11, Could you assign this issue to me as well. Thanks

@drishtigehi drishtigehi mentioned this issue Oct 6, 2022
Closed
@drishtigehi
Copy link

kindly review #196 @guyluz11

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 8, 2022

Hi @drishtigehi I am removing you from Assignees but your pr will still be merged if it will be accepted

Thanks

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 8, 2022

Updating readme with the new line it should be replaced with

@urvisinghal urvisinghal mentioned this issue Oct 8, 2022
Merged
@guyluz11 guyluz11 linked a pull request Oct 8, 2022 that will close this issue
fix: ignore file in git action dart format #202
Merged
@guyluz11 guyluz11 added the hacktoberfest-accepted Accept for hacktoberfest label Oct 16, 2022
@guyluz11
Copy link
Member Author

Closing as it got merged

@guyluz11 guyluz11 mentioned this issue Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore file in git action dart format urvisinghal/cbj_hub
3 participants
@guyluz11 @drishtigehi @bilal-aamer