Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing fails if algorithm, compression_mechanism, or encryption_mechanism are not present #326

Closed
emmanvg opened this issue Dec 3, 2019 · 0 comments · Fixed by #327
Closed
Milestone

Comments

@emmanvg
Copy link
Contributor

emmanvg commented Dec 3, 2019

For Encoding, Encryption and Compression API classes we have a Factory that currently is limited in its extensibility. If the class is not found in the if/else clause it will fail hard. Propose a way to register new API classes, as a fallback it will create the an instance of the default class. Yet, keep in mind that trying to access the Articfact.packed_data or Artifact.data properties may return in a NotImplementedError because pack() and unpack() methods are not defined for base classes.

This fix would allow to interact with the parsed object even if a valid API class is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant