Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for external signals #103

Merged
merged 8 commits into from May 17, 2021
Merged

Added functionality for external signals #103

merged 8 commits into from May 17, 2021

Conversation

ShogunMan
Copy link
Collaborator

@ShogunMan ShogunMan commented May 16, 2021

Created subfolder signals
Any file with extention .exs will be picked up and parsed
It should be a text file with a list of pairs to be traded.
The file will be removed after it has been picked up

@MikkMakk
Copy link
Contributor

So are you running a second script to obtain Signals and then save them into the Signals Directory and This Bot buys these Pairs from the exs file?

@ShogunMan
Copy link
Collaborator Author

Yes, thats how it works.

@ShogunMan
Copy link
Collaborator Author

Added sample singnals module. It has its own tickerlist.
Just run from same directory as main program.

@@ -118,7 +128,7 @@ def wait_for_price():
max_price = max(historical_prices, key = lambda x: -1 if x is None else float(x[coin]['price']))

threshold_check = (-1.0 if min_price[coin]['time'] > max_price[coin]['time'] else 1.0) * (float(max_price[coin]['price']) - float(min_price[coin]['price'])) / float(min_price[coin]['price']) * 100

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove trailing spaces

LOG_TRADES: True
LOG_FILE: 'trades.txt'


# These options apply to the trading methods the script executes
trading_options:
# select what to pair the coins to and pull all coins paired with PAIR_WITH
# select what to pair the coins to and pull all coins paied with PAIR_WITH

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

PAIR_WITH: USDT

# Total amount per trade
# Total ammount per trade

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

QUANTITY: 15

# List of pairs to exclude
# List of pairs to exlcude

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@mindflvx
Copy link

This is great, thanks.

Is there an easy way to choose which indicators to use?

@ShogunMan
Copy link
Collaborator Author

Yes, write your own custom signalling module.

# Setting this to False will use REAL funds, use at your own risk
TEST_MODE: True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably have TEST_MODE = True as default config

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems logical based on the current userbase :-)

@CyberPunkMetalHead CyberPunkMetalHead merged commit 58f4ed9 into CyberPunkMetalHead:main May 17, 2021
@divs1210
Copy link

The bot has stopped making any transactions since this was merged.

Anyone else seeing this?

@divs1210
Copy link

Also, now I have to add pairs myself?

I thought the point of the bot was to detect which pair is mooning and buy it?

@ShogunMan
Copy link
Collaborator Author

For the %increase yes, for external signalling: not with the current samplemodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants