New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality for external signals #103
Conversation
So are you running a second script to obtain Signals and then save them into the Signals Directory and This Bot buys these Pairs from the exs file? |
Yes, thats how it works. |
Added sample singnals module. It has its own tickerlist. |
@@ -118,7 +128,7 @@ def wait_for_price(): | |||
max_price = max(historical_prices, key = lambda x: -1 if x is None else float(x[coin]['price'])) | |||
|
|||
threshold_check = (-1.0 if min_price[coin]['time'] > max_price[coin]['time'] else 1.0) * (float(max_price[coin]['price']) - float(min_price[coin]['price'])) / float(min_price[coin]['price']) * 100 | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove trailing spaces
LOG_TRADES: True | ||
LOG_FILE: 'trades.txt' | ||
|
||
|
||
# These options apply to the trading methods the script executes | ||
trading_options: | ||
# select what to pair the coins to and pull all coins paired with PAIR_WITH | ||
# select what to pair the coins to and pull all coins paied with PAIR_WITH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
PAIR_WITH: USDT | ||
|
||
# Total amount per trade | ||
# Total ammount per trade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
QUANTITY: 15 | ||
|
||
# List of pairs to exclude | ||
# List of pairs to exlcude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
This is great, thanks. Is there an easy way to choose which indicators to use? |
Yes, write your own custom signalling module. |
# Setting this to False will use REAL funds, use at your own risk | ||
TEST_MODE: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably have TEST_MODE = True as default config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, seems logical based on the current userbase :-)
The bot has stopped making any transactions since this was merged. Anyone else seeing this? |
Also, now I have to add pairs myself? I thought the point of the bot was to detect which pair is mooning and buy it? |
For the %increase yes, for external signalling: not with the current samplemodule. |
Created subfolder signals
Any file with extention .exs will be picked up and parsed
It should be a text file with a list of pairs to be traded.
The file will be removed after it has been picked up