Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

[Bug] Silktouch enchantment on shears drop double drop from leaves #220

Closed
CovehiH opened this issue Mar 8, 2016 · 9 comments
Closed

[Bug] Silktouch enchantment on shears drop double drop from leaves #220

CovehiH opened this issue Mar 8, 2016 · 9 comments

Comments

@CovehiH
Copy link

CovehiH commented Mar 8, 2016

Server Log: (Use Pastebin or Github Gist)
N/A

FML Log(s): (Use Pastebin or Github Gist)
N/A

Explanation of issue:
The shears enchanted for silk touch can double-drop from leaves. Can be reproduced on vanilla forge mc.

How to recreate this issue:
It should be clear without details =\

Modpack Name: (Only if public)
Vanilla forge mc

Mods Installed:
Vanilla forge mc

Plugins Installed:
Vanilla forge mc

Thermos Version:
45

Forge Version:
1614

@sameer
Copy link
Member

sameer commented Mar 8, 2016

Did this occur in 44?

@CovehiH
Copy link
Author

CovehiH commented Mar 8, 2016

yup

@sameer
Copy link
Member

sameer commented Mar 8, 2016

This only happens with leaves and no other block?

@sameer
Copy link
Member

sameer commented Mar 8, 2016

Problem identified: ItemShear gets the "sheared" results of an IShearable block. It then drops these items. In the same block break click, ItemInWorldManager calls harvestBlock which also drops a sheared item if silk harvest is available.

If this problem is unique to leaves, then leaves should not check if they are silk harvestable.

@CovehiH
Copy link
Author

CovehiH commented Mar 8, 2016

Hmmm! I can not reproduce it without forge!
It might be worth report issue to forge developers?

@sameer
Copy link
Member

sameer commented Mar 8, 2016

Can you tag them?

@sameer
Copy link
Member

sameer commented Mar 8, 2016

Also, did you figure out if the issue is unique to leaves?

@sameer sameer closed this as completed in 42cef8d Mar 9, 2016
@CovehiH
Copy link
Author

CovehiH commented Mar 9, 2016

Yes! Is unique for all leaves. And modded too.
But fix work only with vanilla leaves :(

@sameer
Copy link
Member

sameer commented Mar 9, 2016

Ok I will see what to do then

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants