Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency resolution should use same logic as dotnet restore #27

Closed
coderpatros opened this issue Nov 7, 2019 · 2 comments
Closed

Comments

@coderpatros
Copy link
Member

Just capturing this as a separate item to #15 and some of the discussion in #20.

In my experience the current logic resolves dependencies the same as a standard dotnet restore does. However there could be some corner cases where the behaviour is different.

To ensure dependency resolution is correct I think we should be using the standard nuget libraries as published from https://github.com/NuGet/NuGet.Client

@coderpatros
Copy link
Member Author

In case anyone comes across this issue I am actively working on it.

@coderpatros
Copy link
Member Author

I'm going to close this with a caveat, we should probably support --framework and --runtime parameters. Or alternatively/additionally the --no-restore option to give users more control. But I think new behaviour introduced in #42 should cover most requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant