Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Builders.FromNodePackageJson.ComponentBuilder cuts names after second slash #599

Closed
jkowalleck opened this issue Mar 29, 2023 · 0 comments · Fixed by #600
Closed

BUG: Builders.FromNodePackageJson.ComponentBuilder cuts names after second slash #599

jkowalleck opened this issue Mar 29, 2023 · 0 comments · Fixed by #600
Labels
bug Something isn't working

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Mar 29, 2023

Even though https://npmjs.org does not allow it, there is nothing wrong with a package name that contains more than one slash(/).
It is completely compliant to NodeJS rules and will be properly resolved. read PackageJson spec

examples:

  • @foo/bar - group: @foo, name: bar
  • @foo/bar/baz - group: @foo, name: bar/baz
  • foo/bar - - group: none, name: foo/bar

current implementation of Builders.FromNodePackageJson.ComponentBuilder cuts off everything after (and including) the second slash(/)
This is unacceptable and should be changed.

@jkowalleck jkowalleck added the bug Something isn't working label Mar 29, 2023
@jkowalleck jkowalleck changed the title BUG: BUG: Builders.FromNodePackageJson.ComponentBuilder cuts names after second slash Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant