Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROPOSAL: rename license-classes to match README #164

Closed
jkowalleck opened this issue Oct 17, 2022 · 0 comments · Fixed by #168
Closed

PROPOSAL: rename license-classes to match README #164

jkowalleck opened this issue Oct 17, 2022 · 0 comments · Fixed by #168
Labels
breaking change
Milestone
v2

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Oct 17, 2022 •
edited

rename some classes so they match the already common names (that are also mentioned in the README alreeady)

  • DisjunctiveLicenseWithName -> NamedLicense
  • DisjunctiveLicenseWithId -> SpdxLicense

rename makeDisjunctiveWithName ??
rename makeDisjunctiveWithId ??
@jkowalleck jkowalleck added this to the v2 milestone Oct 17, 2022
@jkowalleck jkowalleck changed the title PROPOSAL: renamed PROPOSAL: rename to match README Oct 17, 2022
@jkowalleck jkowalleck changed the title PROPOSAL: rename to match README PROPOSAL: rename license-classes to match README Oct 21, 2022
@jkowalleck jkowalleck mentioned this issue Oct 21, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

rename licenses CycloneDX/cyclonedx-php-library
1 participant
@jkowalleck