Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bom-ref for Compomnent and Vulnerability default to a UUID #142

Merged
merged 4 commits into from Jan 24, 2022

Conversation

madpah
Copy link
Collaborator

@madpah madpah commented Jan 24, 2022

Updated logic to ensure bom-ref for Component and Vulnerability have a unique value if not programmatically supplied. We are using a UUIDv4.

Closes #141

Signed-off-by: Paul Horton phorton@sonatype.com

… not supplied ensuring they have a unique value #141

Signed-off-by: Paul Horton <phorton@sonatype.com>
@madpah madpah requested a review from a team as a code owner January 24, 2022 10:28
@madpah madpah self-assigned this Jan 24, 2022
@madpah madpah added the enhancement New feature or request label Jan 24, 2022
Signed-off-by: Paul Horton <phorton@sonatype.com>
Signed-off-by: Paul Horton <phorton@sonatype.com>
Signed-off-by: Paul Horton <phorton@sonatype.com>
@madpah madpah merged commit 3953bb6 into main Jan 24, 2022
@madpah madpah deleted the feat/ensure-bom-ref-for-component-vulnerability branch January 24, 2022 13:28
madpah added a commit that referenced this pull request Jan 26, 2022
* feat: `bom-ref` for Component and Vulnerability default to a UUID if not supplied ensuring they have a unique value #141

Signed-off-by: Paul Horton <phorton@sonatype.com>

* doc: updated documentation to reflect change

Signed-off-by: Paul Horton <phorton@sonatype.com>

* patched other tests to support UUID for bom-ref

Signed-off-by: Paul Horton <phorton@sonatype.com>

* better syntax

Signed-off-by: Paul Horton <phorton@sonatype.com>
madpah added a commit that referenced this pull request Jan 27, 2022
* WIP but a lil hand up for @madpah

Signed-off-by: Jeffry Hesse <5544326+DarthHater@users.noreply.github.com>

* chore: added missing license header

Signed-off-by: Paul Horton <phorton@sonatype.com>

* No default values for required fields

* Add Services to BOM

* Typo fix

* aligned classes with standards, commented out Signature work for now, added first tests for Services

Signed-off-by: Paul Horton <phorton@sonatype.com>

* addressed standards

Signed-off-by: Paul Horton <phorton@sonatype.com>

* 1.2.0

Automatically generated by python-semantic-release

Signed-off-by: Paul Horton <phorton@sonatype.com>

* feat: `bom-ref` for Component and Vulnerability default to a UUID (#142)

* feat: `bom-ref` for Component and Vulnerability default to a UUID if not supplied ensuring they have a unique value #141

Signed-off-by: Paul Horton <phorton@sonatype.com>

* doc: updated documentation to reflect change

Signed-off-by: Paul Horton <phorton@sonatype.com>

* patched other tests to support UUID for bom-ref

Signed-off-by: Paul Horton <phorton@sonatype.com>

* better syntax

Signed-off-by: Paul Horton <phorton@sonatype.com>

* 1.3.0

Automatically generated by python-semantic-release

Signed-off-by: Paul Horton <phorton@sonatype.com>

* WIP but a lil hand up for @madpah

Signed-off-by: Jeffry Hesse <5544326+DarthHater@users.noreply.github.com>
Signed-off-by: Paul Horton <phorton@sonatype.com>

* chore: added missing license header

Signed-off-by: Paul Horton <phorton@sonatype.com>

* aligned classes with standards, commented out Signature work for now, added first tests for Services

Signed-off-by: Paul Horton <phorton@sonatype.com>

* removed signature from this branch

Signed-off-by: Paul Horton <phorton@sonatype.com>

* Add Services to BOM

* Typo fix

* addressed standards

Signed-off-by: Paul Horton <phorton@sonatype.com>

* resolved typing issues from merge

Signed-off-by: Paul Horton <phorton@sonatype.com>

* added a bunch more tests for JSON output

Signed-off-by: Paul Horton <phorton@sonatype.com>

Co-authored-by: Paul Horton <phorton@sonatype.com>
Co-authored-by: github-actions <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Ensure bom-ref for Component and Vulnerability have a (unique) value
2 participants