feat: reduce unnessessarry type casting of set
/SortedSet
when useing setter
#203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show what would happen, if the unnecessary type cast of
set
/SortedSet
was omitted.unnecessary on runtime (as all unit/functional/integration tests are passing),
but
mypy
is not able to detect that the setter has a wider type definition than the getter...see the issue python/mypy#3004
and the decision that the issue is a feature-lack/bug: python/mypy#3004 (comment)
this PR is intended to last for a while and be rebased, whenever needed,
to test if mypy implemented the missing feature, some day.