Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #318

Merged
merged 1 commit into from
Dec 14, 2022
Merged

docs: fix typo #318

merged 1 commit into from
Dec 14, 2022

Conversation

rolweber
Copy link
Contributor

noticed while reading the docs

@rolweber rolweber requested a review from a team as a code owner December 14, 2022 09:23
@jkowalleck
Copy link
Member

thank you for the fix, @rolweber .

i would love to merge it, but i need your consent to publish your work under the license of this project.
therefore, please sign your commit.
Please follow the instructions: https://github.com/CycloneDX/cyclonedx-python-lib/pull/318/checks?check_run_id=10085359274

@jkowalleck jkowalleck changed the title Fix typo docs: fix typo Dec 14, 2022
@jkowalleck jkowalleck added the documentation Improvements or additions to documentation label Dec 14, 2022
@rolweber
Copy link
Contributor Author

I completed the setup for signing commits this morning.
I thought the "Verified" tag indicates that I was successful?
image

@rolweber
Copy link
Contributor Author

Grmpf. Signing isn't enough, I also need to mention in the commit message that it's signed :-?

@jkowalleck
Copy link
Member

re: #318 (comment)
exactly. for legal reasons each commit needs to ne signed-off to indicate that the author acknowledged the projects license and puts their work under said license.

This process is not regarding signed identity but legal signature.
You can read more here:

Signed-off-by: Roland Weber <rolweber@de.ibm.com>
@rolweber
Copy link
Contributor Author

I fell for the difference between -S and -s.

@rolweber
Copy link
Contributor Author

All checks are passing now.

@jkowalleck jkowalleck merged commit 63bfb87 into CycloneDX:main Dec 14, 2022
@rolweber rolweber deleted the fix-typo branch December 14, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants