Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] 4.2.2 puts extra files in root of site-packages #435

Closed
bollwyvl opened this issue Sep 14, 2023 · 5 comments · Fixed by #560
Closed

[BUILD] 4.2.2 puts extra files in root of site-packages #435

bollwyvl opened this issue Sep 14, 2023 · 5 comments · Fixed by #560
Labels

Comments

@bollwyvl
Copy link

A look at the files in the 4.2.2 wheel shows the return of the condition from #336.

On conda-forge, we'll probably just delete them. They are unlikely to truly offend anything (other than other packages that have similar quirks), but just good manners.

@jkowalleck
Copy link
Member

jkowalleck commented Sep 15, 2023

ow, man. sorry.

was caused by #434
was caused by python-poetry/poetry#8441

will see how this can be fixed.

@jkowalleck
Copy link
Member

thing is that this file MUST to be shipped, along with the NOTICE file, for legal reasons.
the files MUST to be shipped, but dont need to be installed.

sorry.

@jkowalleck
Copy link
Member

@bollwyvl I feel bad for the inconvenience,
but i cannot provide a quick fix, unless python-poetry/poetry#8441 got implemented.

@bollwyvl
Copy link
Author

Right, they certainly need to be shipped, but build backends generally seem to have a way to do this where they end up in the .dist-info folder of a wheel. Again, probably not hurting anybody.

@jkowalleck
Copy link
Member

jkowalleck commented Sep 15, 2023

build backend has not proper functionality for it, yet.
a fix depends on python-poetry/poetry#8441

PS: a fix was merged via https://github.com/python-poetry/poetry-core/pull/666/files
waiting for the release :D

@jkowalleck jkowalleck changed the title 4.2.2 puts extra files in root of site-packages [BUILD] 4.2.2 puts extra files in root of site-packages Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants