-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downstream type hints? #52
Comments
thanks you very much for the hint, @woodruffw 👍 |
Awesome, thanks a ton! Let me know if I can help with testing or anything else. |
@woodruffw the release v0.11.0 included PEP 561 compatibility. Could you see if it suites your needs? |
Thanks! I'll test them now. |
Looks like the type hints are working! Thanks a ton for adding them so quickly. The only outstanding issues preventing me from using them are in #61. |
Great news @woodruffw - #61 is merged now and building - point release expected shortly. |
First of all, thanks for this fantastic library!
I'm currently working on using
cyclonedx-python-lib
to generate SBOMs withinpip-audit
.Our codebase is fully typechecked (via MyPy), and it looks like this library is too! But we can't currently consume your type hints, since the
cyclonedx
package doesn't include apy.typed
file per PEP 561.Is there any objection to including that file, so that downstream users can typecheck their API use? If not, I can go ahead and create a PR -- it should be just a 2 or 3 line change.
The text was updated successfully, but these errors were encountered: