Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashes for packages from registries with parameters in the URL may not be recorded #629

Open
Shnatsel opened this issue Feb 25, 2024 · 0 comments

Comments

@Shnatsel
Copy link
Contributor

Cargo.lock does not URL-encode URL parameters in source field correctly right now. A v4 Cargo.lock format is expected to ship sometime soon, fixing that.

We are cross-referencing this field with cargo metadata, which starting with Rust 1.77 outputs cargo pkgid as its package ID representation (at least according to the docs).

We'll need to investigate how cargo pkgid/cargo metadata handle URL-encoding of source parameters and make sure it agrees with the Cargo.lock representation, or work around the discrepancy if it doesn't.

@Shnatsel Shnatsel changed the title Hashes for packages from registries with parameters in the URL may not be recorded correctly Hashes for packages from registries with parameters in the URL may not be recorded Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant