Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist for electrifying other sheep #13

Open
tali713 opened this issue Jan 4, 2018 · 1 comment
Open

Whitelist for electrifying other sheep #13

tali713 opened this issue Jan 4, 2018 · 1 comment
Labels
Projects

Comments

@tali713
Copy link
Contributor

tali713 commented Jan 4, 2018

Not sure if this a bug or a feature request but...

Currently because of the way it is tested The only sheep which may be energized by lightning are vanilla sheep. This is unfortunate, why can't the twilight forests sheep be transformed into a source of energy, and then there is of course Animania, which by default replaces sheep with their own sheep and goat variants.

Of course, this is simply solved by using instanceof, with one or two minor draw backs When struck by lightning Energetic Sheep will now have their wool restored rather than catch on fire. I have mixed feelings about this. Energetic Sheep from Animania will always have white wool and should goats really count?

@rubensworks
Copy link
Member

A better way to handle this, might be to work with an entity class whitelist. Twilight forest and animania animals could then be added to this list.

@rubensworks rubensworks added this to Options in Features via automation Jan 4, 2018
@rubensworks rubensworks changed the title Electrifying other sheep Whitelist for electrifying other sheep Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Features
  
Options
Development

No branches or pull requests

2 participants