Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.14] Rendered Images cut off #7

Closed
IronPiston opened this issue Nov 25, 2019 · 15 comments
Closed

[1.14] Rendered Images cut off #7

IronPiston opened this issue Nov 25, 2019 · 15 comments
Labels
Projects

Comments

@IronPiston
Copy link

Issue type:

  • 馃悰 Bug

Short description:

After trying to render, the resulting were only the top left.
Screenshot from 2019-11-24 18-23-50

Steps to reproduce the problem:

Run /iconexporter export [any scale]

Expected behaviour:

The images should be the full sprite/model, not a portion.


Versions:

  • This mod: 1.2.0
  • Minecraft: 1.14.4
  • Forge: 28.1.92
@rubensworks
Copy link
Member

Weird, it works with any scale for me...

What scale did you use for the screenshot above?

What OS are you using?

@IronPiston
Copy link
Author

Scale for that screenshot was 512, but 32 gave the same problem.

I'm using Fedora 30 I think, I haven't updated in a while.

Weirdly, the 1.12 version works fine on the same computer.

@rubensworks
Copy link
Member

I can't reproduce this myself unfortunately (works fine on Mac).
If someone running on Linux would be able to debug this, that'd be great.

@rubensworks rubensworks moved this from To Do to On hold (awaiting input) in Maintenance Dec 29, 2019
@IronPiston
Copy link
Author

So I just tried again, and the issue seems to be gone(I just reinstalled Fedora in the last few days). This seems to have been a problem on my end, since the mod hasn't updated since I posted this issue.

@rubensworks
Copy link
Member

That's good to hear, closing this then.
Should anyone else experience this problem in the future, feel free to comment here.

Maintenance automation moved this from On hold (awaiting input) to Done Jan 14, 2020
@Krutoy242
Copy link

1.12.2
First run of export command gave right result. But than i tried to enable general.fileNameHashTag=true. Now no matter of size i set - everything exported in half.
I already tried to return options to original or reload minecraft - problem still here.

After some investigation, i found that it somehow connected with MC window size - when i resized window to maximum - problem disapear.

@rubensworks
Copy link
Member

@Krutoy242 What OS are you using?

@rubensworks rubensworks reopened this Jun 5, 2020
Maintenance automation moved this from Done to To Do Jun 5, 2020
@Krutoy242
Copy link

Krutoy242 commented Jun 5, 2020

@Krutoy242 What OS are you using?

Windows 10

@rubensworks
Copy link
Member

I'll look into it again in any case, but I'm using Mac, so I'm not able to do any debugging on Windows unfortunately.

@rubensworks
Copy link
Member

I'm unable to reproduce this myself (on Mac) with different resolutions.

I highly suspect this is an OS-specific issue. Since I'm not able to debug this myself, I hope someone else is able to find the problem and suggest a PR.

@rubensworks rubensworks removed this from To Do in Maintenance Sep 11, 2020
@MindGames18
Copy link

Hello there @rubensworks . I had the same issue in my windows 10. the exported icons were cut off partially.
and after some time investigating it myself, I ended up finding out that turning the gameto full screen (F11 default for windows) before exporting fixes this issue.

Maybe you'll be able to reproduce this in mac if you try exporting from windowed mode (speculating)
thanks! hope this info helps you and others who may stumble here

@rubensworks rubensworks added this to To Do in Maintenance via automation Oct 17, 2020
@rubensworks
Copy link
Member

Note to self: auto-toggle full-screen mode when exporting.

@rubensworks rubensworks moved this from To Do to To Do (Minor) in Maintenance Jan 1, 2021
@Hekera
Copy link

Hekera commented Apr 10, 2021

I think I've found the source of the issue, at least on Windows. It has to do with the GUI scale option in Minecraft video settings, which I've had on Auto. Changing resolutions/system scale/fullscreen around produces different results because it changes the GUI scale that Minecraft automatically determines. Once I set the GUI scale to a specific number, the results of the icon export remained consistent between resolutions/etc. GUI scale 2 seems to export icons that are the actual scale specified in the command, and that are not cut off.

@DarkAngel22579
Copy link

Chiming in with a 1080p monitor (since Hek's is 1440p). Setting the GUI scale to 2 makes it export at the right scale, regardless of fullscreen/windowed. I normally have GUI set to 3, which caused a 50% increase in the size of the icons. I'd assume GUI scale 1 would cause a 50% decrease, but I haven't tested that.

@rubensworks
Copy link
Member

Thanks for all the input. I've managed to reproduce the problem with different GUI scales.
Fix incoming...

Maintenance automation moved this from To Do (Minor) to Done Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Maintenance
  
Done
Development

No branches or pull requests

6 participants