Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathway to v1.0 #51

Draft
wants to merge 407 commits into
base: master
Choose a base branch
from
Draft

Pathway to v1.0 #51

wants to merge 407 commits into from

Conversation

CyprienBosserelle
Copy link
Owner

@CyprienBosserelle CyprienBosserelle commented Oct 26, 2021

Pathway to v1.0

BG-Flood is nearing a major milestone.

New major features

  • Add Buttinger et al. reconstruction with HLLC engine and wet slope limiter
  • Add Block average scheme elevation and roughness when block dx > forcing dx
  • Add Polygon domain for improved memory requirement
  • Allow Sub-region output to only output a smaller area than the full domain and save some HD space
  • Full implementation of adaptive grid
  • Initial and continuing loss
  • Spherical (lat lon) coordinates
  • Improve documentation and tutorials

New minor feature

  • Rain-on-grid internal test
  • Multiple Bathy file input
  • Revamped tests
  • Force initial dt for dry models to be small enough wrt forcing
  • Crash detection (for tiny dt)
  • Flag to select Kurganov vs Buttinger engine
  • Internal test for boundaries
  • Continuous integration with internal tests on CPU and GPU
  • Param file as an input to exec
  • Auto-copy of code to gitlab
  • Code optimization
  • Add NetCDF CRS and time metadata to output
  • Add param settings to NetCDF (metadata?)
  • Handle input forcing where dx != dy

minor Changes

  • General code cleanup and reduce compile-time warnings
  • Add Jupyter (Python) and Pluto (Julia) tutorial notebooks in demo
  • Add active cell to limit rain to within specify domain
  • Check/verify/Fix initial time step sanity
  • Fix wet/dry instabilities
  • Improve/fix absorbing bnds
  • Add tutorial/docs for tsunami initiation
  • Add tutorial/docs for wind/atmpress forcing
  • Add speed benchmark to compare with other codes (Tuflow benchmark?)
  • Rain depth forcing option (rain intensity is default)
  • Read time stamp from Netcdf and param file
  • Add user defined log file name
  • Fix nesting capability

Major Fix

  • Bug fix for refine linear function
  • Full rewrite of gradient calculation to be in line with refine linear
  • Fix hotstart to use new variable name
  • Fix Timeseries Output
  • Fix compiling issues with older GCC
  • Fix rain map input

Minor Fix

  • Fix crash when specified river is outside the model domain (4a2513c)
  • Fix round-off error with small domain
  • Fix round-off error for bathy interpolation
  • Fix river footprint when the input discharge area is smaller than block resolution
  • Fix resetmax
  • Fix deform input
  • Fix atm pressure forcing engine
  • Fix absorbing bnd issues with wet/dry

@CyprienBosserelle CyprienBosserelle changed the title Development Pathway to v1.0 Oct 26, 2021
@CyprienBosserelle CyprienBosserelle marked this pull request as draft October 27, 2021 09:14
CyprienBosserelle and others added 30 commits July 24, 2023 20:43
To manually compile on linux
for compilation less permissive
declaration for less permissive compilation
update version
## Spherical (#78)

* Add spherical fix to main kurganov

* add cm and fm functions for spherical correction

* replaced dx with delta where necessary

    delta is the cell size in m. whereas dx is for spherical grid units. for metric type grids dx == delta

* Fix Spherical calculations

* Update Makefile

* Create codemap.md

* add synonym for spherical

* debug Nesting SPHerical

* Fix Spherical adaptive

* Fix error_new CalcFM funct

* Missed a fix for new CalcFM

* Try fix CalcFM

* Arggggh

* test fix fmvp

* testfix2

* Reverting non-working fix

* revert the non-working CPU fix

* DEBUG spherical correction

* Revert Calcres modification



* Update gradient call to use delta

* Update gradient call to use delta

* Remove Printf in update function

* Update dx to delta in gradient halo on GPU

* Fix lake_at_rest issue

* Add Bool param read function

* Fix texture filter mode

* add Function for river area

* Fix Compile Bugs

* Test No coarsening

* Fix to resolve complaint from compiler

* try fix compiler complaint

* Fix edge clamp for atmp pressure

* Fix for flipy check

* Dxdy forcing (#91)

* Add dy to forcing and interpolation

* swich on the change

* Fix for using dy in Forcing

* Update Testing.cu

* atmp warm start +bnd

* add cm to Buttinger reconstruction

* Fix Y direction correction for Butt. engine

* Remove requirement on engine 2 when sph is requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants