Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullReferenceException due to Key being Null in ‎MagicalBox.ReaderCache #158

Open
fitdev opened this issue Apr 15, 2024 · 0 comments
Open

Comments

@fitdev
Copy link

fitdev commented Apr 15, 2024

When I was debugging the code for issue #157 , I got a lot of NullReferenceExceptions in ‎MagicalBox complaining that dictionary's key is null, apparently nulls get passed to Dictionary lookup routines, where a concrete Type instance is expected for the key.

Since this library intends to be highly performant, throwing such exceptions is not good, and it would be better to avoid such calls by checking in advance if key is null and simply not performing dictionary lookups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant