Doc: Runtime patching on Node.js

[d9k]

Does this library supports runtime patching (without the use of webpack at all)?

inside node interpreter:

MR = require('mock-requests');
fetch = require('node-fetch');

MR.setMockUrlResponse('http://t/1', {
  mockExample: 1
});

fetch('http://t/1').then((response) => response.json()).then(data => console.log(data));
// request fails

[d9k]

fetch = require('node-fetch');
global.fetch = fetch
MR = require('mock-requests');

MR.setMockUrlResponse('http://localhost:1111/t', {
  mockExample: 1
});

fetch('http://localhost:1111/t').then((response) => response.json()).then(data => console.log(data));
// request fails

[d9k]

OK, found a solution

global.fetch = require('node-fetch');
global.Headers = fetch.Headers;
MR = require('mock-requests');

MR.setMockUrlResponse('http://localhost:1111/t', {
  mockExample: 1
});

fetch('http://localhost:1111/t').then((response) => response.json()).then(data => console.log(data));
// works OK

[D-Pow]

This is a great catch, @d9k!

As you mentioned, node-fetch recommends its users to patch the global.fetch function in order to use it. That's why I've typically favored using isomorphic-fetch in the past for both browser and node polyfills -- because it automatically patches everything for the user.

That being said, this should be made specifically clear in the MockRequests docs so that other users aren't left scratching their heads over why it's not working as expected. I'll leave this issue open until I push the update.

[D-Pow]

This should be fixed in PR #17. Please let me know if you still encounter any issues!