Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove dependency of dmd on .cloned" #1074

Merged
merged 1 commit into from
Aug 23, 2015

Conversation

aG0aep6G
Copy link
Contributor

Reverts #1050

Fixes issue 14915 - [REG2.068.0] can't build phobos-release

I don't know how to do properly what #1050 aimed for. In the short term, I think it's more important to get a working build again.

${MAKE} --directory=${DMD_DIR}/src -f posix.mak -j 4

$(DMD_REL):
$(DMD_REL) : ${DMD_DIR}-${LATEST}/.cloned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make those depend on ${DMD_DIR}/src/dmd to address the main point of #1050, see #1050 (comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, it's already like it should be. We depend on dmd/src/dmd which itself depends on .cloned.

MartinNowak added a commit that referenced this pull request Aug 23, 2015
Revert "Remove dependency of dmd on .cloned"
@MartinNowak MartinNowak merged commit 20ee20a into dlang:master Aug 23, 2015
@CyberShadow
Copy link
Member

I think only reverting the second part would fix the build problem at hand while also not touching whatever @andralex was actually trying to fix.

@CyberShadow
Copy link
Member

I still don't see any issue with adding a touch invocation, I think it would fix everything.

@CyberShadow
Copy link
Member

An alternative would be to instead of depending on a .cloned file we made up, to depend on a source file we know is going to be in the tree and that is part of the dmd build process.

@MartinNowak
Copy link
Member

An alternative would be to instead of depending on a .cloned file we made up, to depend on a source file we know is going to be in the tree and that is part of the dmd build process.

I have a better solution already, but forgot to post it, b/c I got distracted doing other stuff.

@MartinNowak
Copy link
Member

See #1077

@aG0aep6G aG0aep6G deleted the revert-1050-no.cloned branch August 23, 2015 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants