-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove dependency of dmd on .cloned" #1074
Conversation
${MAKE} --directory=${DMD_DIR}/src -f posix.mak -j 4 | ||
|
||
$(DMD_REL): | ||
$(DMD_REL) : ${DMD_DIR}-${LATEST}/.cloned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make those depend on ${DMD_DIR}/src/dmd
to address the main point of #1050, see #1050 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, it's already like it should be. We depend on dmd/src/dmd which itself depends on .cloned.
Revert "Remove dependency of dmd on .cloned"
I think only reverting the second part would fix the build problem at hand while also not touching whatever @andralex was actually trying to fix. |
I still don't see any issue with adding a |
An alternative would be to instead of depending on a |
I have a better solution already, but forgot to post it, b/c I got distracted doing other stuff. |
See #1077 |
Reverts #1050
Fixes issue 14915 - [REG2.068.0] can't build phobos-release
I don't know how to do properly what #1050 aimed for. In the short term, I think it's more important to get a working build again.