Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla 12623 #557

Merged
merged 1 commit into from Apr 25, 2014
Merged

Fix Bugzilla 12623 #557

merged 1 commit into from Apr 25, 2014

Conversation

Hackerpilot
Copy link
Member

No description provided.

@CyberShadow
Copy link
Member

https://issues.dlang.org/show_bug.cgi?id=12623

Nit: please format your pulls according to http://wiki.dlang.org/Pull_Requests#Create_a_pull_request in the future.

@Hackerpilot
Copy link
Member Author

I think that link should have been https://issues.dlang.org/show_bug.cgi?id=12623

MartinNowak added a commit that referenced this pull request Apr 25, 2014
@MartinNowak MartinNowak merged commit 7b07400 into dlang:master Apr 25, 2014
@CyberShadow
Copy link
Member

Fixed :)

@denis-sh
Copy link
Contributor

denis-sh commented May 2, 2014

Am I the only one here thinking the fact 1. a and 1.a are parsed differently looks like a compiler bug? If there is some discussion and reasoning about this behaviour it must be added to the documentation.

@Hackerpilot
Copy link
Member Author

I think the intention was for UFCS to work with integer literals and for 1. to be a valid floating point literal. I personally think that this is a dumb idea, but I'm tired of the documentation being inconsistent with the compiler's behavior and this was easier than fighting another "the compiler should not accept this" fight.

@denis-sh
Copy link
Contributor

denis-sh commented May 2, 2014

We can't just document all dmd bugs and be happy. Actually we can, but shouldn't.

@MartinNowak
Copy link
Member

Deprecating 1. as floating point literal would be hard, because it's valid C.

@ghost
Copy link

ghost commented May 5, 2014

I seem to recall we have already deprecated something similar. Was it just 1.f to allow UFCS? Strange that we've left 1. work though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants