New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for 2.066 release #616
Conversation
) | ||
|
||
$(BUGSTITLE Library Changes, | ||
$(LI $(RELATIVE_LINK2 array_and_aa_changes, Some built-in type properties are changed to library funcitons.)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funcitons -> functions
$(LI $(RELATIVE_LINK2 boundscheck, $(D -noboundscheck) has been deprecated in favor of | ||
$(D boundscheck=[on|safeonly|off]).)) | ||
$(LI $(RELATIVE_LINK2 boundscheck, $(D -noboundscheck) has been deprecated in favor of $(D boundscheck=[on|safeonly|off]).)) | ||
$(LI $(RELATIVE_LINK2 vcolumns_switch, $(D -vcolumns) is added to display column numbers in error messages.)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use past or present tense? Whatever the choice, it should be consistent. s/is added/was added/
?
@CyberShadow Updated. Thanks! |
$(LI $(RELATIVE_LINK2 opover_multidim_slicing, Operator overloading feature for multi-dimensional slicing is added.)) | ||
$(LI $(RELATIVE_LINK2 traits_getfunctionattributes, $(D __traits$(LPAREN)getFunctionAttributes$(RPAREN)) is added.)) | ||
$(LI $(RELATIVE_LINK2 narrowing_conversion_in_ifti, Support template parameter deduction with arguments narrowing conversion.)) | ||
$(LI $(RELATIVE_LINK2 unique_expression, Unique expression concept is reinforced.)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This item seems to be missing any notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've listed it for the DIP29 working which was done by @WalterBright, but I couldn't explain it well. Removed.
I've written a note about |
@ntrel Sorry I won't pull your PR into here. Instead you can open a PR against the official repo https://github.com/D-Programming-Language/dlang.org . |
Updated description about AA changes. |
$(LI $(RELATIVE_LINK2 boundscheck, $(D -noboundscheck) has been deprecated in favor of $(D boundscheck=[on|safeonly|off]).)) | ||
$(LI $(RELATIVE_LINK2 vcolumns_switch, $(D -vcolumns) was added to display column numbers in error messages.)) | ||
$(LI $(RELATIVE_LINK2 vgc_switch, $(D -vgc) was added to list GC allocation code positions in the code.)) | ||
$(LI $(RELATIVE_LINK2 color_switch, $(D -color) was added to make console output colored.)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd order these in level of importance, and group related ones together. So please put the vgc
stuff on top and make vcolumns
and color
next to each other rather than being mixed with the important vgc
stuff. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In these items, warn_unused_retval
is the most important change (some user code will make error with -w switch). Next is boundscheck
(using -noboundscheck
will be deprecated). Remains have low priority than the two, but I agree that moving vgc_switch
on top of the three.
Can anyone who's been active in the last couple of months have a quick glance and see if there's any major changes missing from the changelog? As you can tell I haven't been up to date with things recently. |
Looks good to me. Didn't see any blatant missing things. |
@AndrejMitrovic Updated wording. |
See 9rnsr#2 for some minor improvements to the wording. |
Thanks, looks good! |
) | ||
) | ||
|
||
$(LI $(LNAME2 aa_key_requirement, Associative array keys now require equality rather than ordering:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is a breaking change, it should probably be the first one listed under Library Changes. Perhaps use $(RED ...)
for the title too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Also, might be helpful to state that if opCmp
is defined in a compatible way with opEquals
, then user code doesn't need to be changed. This should reduce user outrage at Yet Another AA change. ;-)
Minor fixes to improve readability
I cherry-picked the pull request posted by by @ntrel. |
First, thanks @AndrejMitrovic, @9rnsr and everyone who reviewed this request. It's time to start final preparations for the 2.066 release. I will be merging this pull shortly and cherry-picking it to the 2.066 branch. |
Update changelog for 2.066 release
Please review English wording.