Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 12241 - Document change to static opCall #619

Merged
3 commits merged into from Aug 3, 2014

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jul 24, 2014

https://issues.dlang.org/show_bug.cgi?id=12241

  • update operator overloading docs
  • late update of the 2.065 changelog

@ntrel ntrel changed the title Fix Issue 12241 - Document change to static opCall in changelog Fix Issue 12241 - Document change to static opCall Jul 26, 2014
this(int i) {}
static S opCall() // disallowed due to constructor
{
return S();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have called itself, return S.init instead.

@MartinNowak
Copy link
Member

LGTM otherwise

@ntrel
Copy link
Contributor Author

ntrel commented Jul 28, 2014

Fixed to use S.init, thanks.

@ghost
Copy link

ghost commented Aug 3, 2014

Looks good, thanks!

ghost pushed a commit that referenced this pull request Aug 3, 2014
Fix Issue 12241 - Document change to static opCall
@ghost ghost merged commit 9c7ab18 into dlang:master Aug 3, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants