Fix grammar around function declaration #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuncDeclarator is a dup of Declarator, and FuncDeclaratorSuffix is a dup of DeclaratorSuffix And we need to keep function type aliasing with the old style syntax.
Remove FuncDeclaratorSuffixes to disallow zero, two or more parameter lists And disallow mixing C-style suffix in function declaration, as follows: void foo[](int a);
…ations Move FuncDeclaration and related non terminal symbols into function.dd Conflicts: declaration.dd grammar.dd
|
@Hackerpilot Could you review this change? |
|
|
||
| $(GNAME DefaultInitializerExpression): | ||
| $(ASSIGNEXPRESSION) | ||
| $(GLINK2 traits, SpecialKeyword) |
There was a problem hiding this comment.
SpecialKeyword is already present in the PrimaryExpression rule. I think we can remove this and let the AssignExpression rule handle special keywords.
There was a problem hiding this comment.
Hmm, seems correct. I'll file the issue in bugizlla, then open a new PR to fix it.
There was a problem hiding this comment.
|
This change looks good (ignoring the DefaultInitializerExpression issue). |
|
@Hackerpilot Thanks for your review. |
|
I'll merge this PR so this is just a cleanup. |
9rnsr
added a commit
that referenced
this pull request
Sep 24, 2014
Fix grammar around function declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 10235 - Grammar does not contain a rule for function declarations
Issue 12579 - DMD rejects valid function literal
Issue 13523 - Auto function declaration does not match any grammar rule
And I moved function-related grammars,
Parameters,FunctionAttribute,MemberFunctionAttribute, etc into thefunction.htmlpage.