Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a note that no longer reflects how D works #975

Merged
merged 1 commit into from Apr 25, 2015
Merged

Fix a note that no longer reflects how D works #975

merged 1 commit into from Apr 25, 2015

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Apr 23, 2015

Reasoning:

while (1)
{
    try {
        break;
    }
    finally {
        goto label;   // Compiler error
        return 1;     // Compiler error
    }
}

CyberShadow
CyberShadow reviewed Apr 23, 2015
View reviewed changes
statement.dd
$(P $(D Note:) If a finally clause executes a return, throw, or goto
out of the finally clause,
the continue target is never reached.)
$(P $(D Note:) If a finally clause executes a throw own of the finally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

own? out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fat fingers. :)

MartinNowak added a commit that referenced this pull request Apr 25, 2015
@MartinNowak
Merge pull request #975 from ibuclaw/target_never_reached
9200665 
Fix a note that no longer reflects how D works
@MartinNowak MartinNowak merged commit 9200665 into dlang:master Apr 25, 2015
@ibuclaw ibuclaw deleted the target_never_reached branch April 26, 2015 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ibuclaw @CyberShadow @MartinNowak