Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Commit

Permalink
always create zip file
Browse files Browse the repository at this point in the history
  • Loading branch information
@WalterBright
WalterBright committed Jan 3, 2013
1 parent 8c9bfe2 commit 3ad3f7c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions posix.mak
View file
Expand Up @@ -652,11 +652,11 @@ detab:
detab $(MANIFEST)
tolf $(MANIFEST)

zip: druntime.zip
zip:
zip druntime.zip $(MANIFEST) $(DOCS) $(IMPORTS) minit.o

druntime.zip:
rm -f $@
zip -u $@ $(MANIFEST) $(DOCS) $(IMPORTS) minit.o
zip $@ $(MANIFEST) $(DOCS) $(IMPORTS) minit.o

install: druntime.zip
unzip -o druntime.zip -d /dmd2/src/druntime
Expand Down

7 comments on commit 3ad3f7c

@andralex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WalterBright What is the problem this solves? Also I disagree with the solution as it introduces duplication. The correct approach is to have zip depend on druntime.zip, as before.

@WalterBright
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was that if druntime.zip already existed, running:

make zip

would do nothing.

@andralex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correctly done with a FORCE target, see http://www.gnu.org/software/make/manual/html_node/Force-Targets.html. At any rate, now that the release is out there you need to resort to making pull requests like everyone else. The power of democracy!

@braddr
Copy link
Member

@braddr braddr commented on 3ad3f7c Jan 3, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andralex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@braddr that was a joke

@WalterBright
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also the rm followed by the zip -u. One or the other is redundant.

@andralex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#374

Please sign in to comment.