This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
gc.gc: Fix out-of-bounds pagetable access #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberShadow
force-pushed
the
pull-20150324-224917
branch
from
5b5932a
to
e21c2ac
Compare
CyberShadow
added a commit
to CyberShadow/druntime
that referenced
this pull request
Mar 25, 2015
|
IIRC the check |
|
Oh, OK. |
We never check that `i + p < npages`. Found using Vagrind.
CyberShadow
force-pushed
the
pull-20150324-224917
branch
from
e21c2ac
to
bb7e7c3
Compare
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
Mar 27, 2015
gc.gc: Fix out-of-bounds pagetable access
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The out-of-bounds access occurs 3 lines below:
pagetable[i + p]We never check that
i + p < npages.This patch also acts as a small optimization (don't look at the last
n-1pages because it's impossible to find a free chunk of at leastnpages from those positions).Found using Vagrind: #1197 (comment)