TickDuration UFCS "to" was broken for float

[burner]

#1190 was not tested throughout, it has a missing "this".

TickDuration t;
auto tf = to!("nsecs",float)(t);

Update:
found this while making the plotting for my benchmark module better

Update2:
best PR number ever :-)

[andralex]

space after cast(T)

[andralex]

this needs a fair amount of work

[burner]

@jmdavis how can I use monotime with the StopWatch. I found this bug because I was working with the StopWatch.

@andralex indeed this needs works

[jmdavis]

how can I use monotime with the StopWatch. I found this bug because I was working with the StopWatch.

You can't right now, because that would be a breaking change. The benchmarking code in std.datetime would mostly work as-is with MonoTime and Duration instead of TickDuration except for that fact that it's primarily return types that change (so they can't be overloaded). So, those functions are going to need to be replaced with versions using MonoTime and Duration in another module like std.benchmark, at which point, the versions in std.datetime, which use TickDuration can be deprecated along with TickDuration itself, and it should then be easier to deal with the benchmarking functions, since the confusion that is TickDuration won't be needed. Those new functions are on my TODO list, but I haven't managed to find much time for D in the past several months. I think that that will be changing soon, but my primary focus at the moment will be dconf, or I won't have my talk ready in time, so changes like that will almost certainly have to come after. So until I get to it (or someone else does), we unfortunately have to make do with TickDuration when dealing with the benchmarking functions. But we did finally get MonoTime in the last release, so the necessary building blocks are now there.

[burner]

linux_32_64

shared static ~this() groot = (nil)
timed out after 3600 seconds, step failed

not sure what is the cause of this, but the core.time tests pass

[mrkline]

Thanks for really digging into this - my original PR was extremely simple and just hoisted to out of Duration so that it matched the rest of the standard library's semantics. I noticed some of this seemed a bit off, but didn't want to hoist it out and do a rewrite all at once. My apologies for any resulting kerfuffles.

[MartinNowak]

It's usually better to turn those foreach into a function literal to mitigate the expensive O(N^2) optimizations of the backend.

[MartinNowak]

Auto-merge toggled on

[burner]

thanks