Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Add constants AF_RXRPC and PF_RXRPC on Linux #1334

Merged
merged 4 commits into from Nov 13, 2015

Conversation

todayman
Copy link
Contributor

See title. Pretty simple and self-explanatory.

@DmitryOlshansky
Copy link
Member

Since these are linux specific no point having them on posix file I guess.
@todayman - could you please follow the convention of putting things into core.sys.linux.* if they are linux-specific?

@todayman
Copy link
Contributor Author

There isn't a core.sys.linux.sys.socket.d. Should I go ahead and create or do you think there's a better place?

@DmitryOlshansky
Copy link
Member

Time to create ore.sys.linux.sys.socket.d

@todayman todayman force-pushed the rxrpc_constants branch 3 times, most recently from 676c4e0 to d882812 Compare September 23, 2015 00:35
@todayman
Copy link
Contributor Author

The autotester has been stuck at Pass: 8, Pending: 2 for quite a while now (> 1 week). What does that mean? Clicking on the details link shows that there are some failures on Win32 - if those are a real problem I have no way to test / debug those and would appreciate help.

@yebblies
Copy link
Member

The autotester prioritizes recently-updated pulls, and on some of the slower platforms this means the tester never gets to this pull. If you rebase on top of master and force-push over this branch it will bump it back up to the top.

@todayman todayman force-pushed the rxrpc_constants branch 2 times, most recently from 5c4c39f to 48e41b3 Compare October 27, 2015 01:12
@todayman
Copy link
Contributor Author

@DmitryOlshansky core.sys.linux.sys.socket.d is made and the build looks OK. Is this good to go?

@schveiguy
Copy link
Member

LGTM

@nogc:
nothrow:

enum {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should publicly import core.sys.posix.sys.socket; so it functions as an overlay.

@todayman
Copy link
Contributor Author

@MartinNowak public import added.

@schveiguy
Copy link
Member

Still looks good, I assume Martin only had that one issue which is now fixed.

@schveiguy
Copy link
Member

Auto-merge toggled on

schveiguy added a commit that referenced this pull request Nov 13, 2015
Add constants AF_RXRPC and PF_RXRPC on Linux
@schveiguy schveiguy merged commit 93457e8 into dlang:master Nov 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants