This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
fix Issue 15268 - deadlock for Thread.getAll/Thread.opApply #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Oct 31, 2015
MartinNowak
commented
- fix a deadlock caused by lock order inversion
- must not use the GC while holding slock
- both Thread.remove and thread_suspendAll synchronize on slock so a double removal isn't possible - we still set isRunning to false b/c some functions must not be called on a stopped thread, e.g. setPriority
- happens when removing a running thread (thread_detachInstance) that gets removed again at the end of thread_entryPoint - fixed by setting .prev/.next to null on removal and checking for that - requires the obvious care when removing threads while looping over the list - also helps the GC a bit to collect dead Thread objects
- fix a deadlock caused by lock order inversion - must not use the GC while holding slock
This was referenced Oct 31, 2015
|
Auto-merge toggled on |
dnadlinger
added a commit
that referenced
this pull request
Oct 31, 2015
fix Issue 15268 - deadlock for Thread.getAll/Thread.opApply
|
Well, here goes nothing. I've tried my best to verify the changes, but it's pretty easy to mess up that piece of code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.