This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix 11761: aa.byKey and aa.byValue are not forward ranges. #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that Phobos' `isForwardRange` template requires that `.save` must be `@property`, otherwise it does not acknowledge the range as a forward range; however, aa.byKey and aa.byValue's `.save` weren't marked as such. This PR fixes this problem and introduces a unittest to ensure the forward range criteria are satisfied.
|
I'd DRY up the unit test, considering we want a |
|
Done. Even threw in a test for |
|
Link to the bugzilla report: https://issues.dlang.org/show_bug.cgi?id=11761 And, the fix looks good to me. |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Aug 15, 2014
Fix 11761: aa.byKey and aa.byValue are not forward ranges.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that Phobos'
isForwardRangetemplate requires that.savemust be@property, otherwise it does not acknowledge the rangeas a forward range; however, aa.byKey and aa.byValue's
.saveweren'tmarked as such. This PR fixes this problem and introduces a unittest to
ensure the forward range criteria are satisfied.