Avoid double lookup in opIndex for std.json.

dlang · May 23, 2014 · 7ac188b · 7ac188b
1 parent 8d5686a
commit 7ac188b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/std/json.d b/std/json.d
@@ -337,9 +337,10 @@ struct JSONValue
     /// Throws $(D JSONException) if $(D type) is not $(D JSON_TYPE.OBJECT).
     ref inout(JSONValue) opIndex(string k) inout
     {
-        enforceEx!JSONException(k in this,
-                                "Key not found: " ~ k);
-        return store.object[k];
+        enforceEx!JSONException(type == JSON_TYPE.OBJECT,
+                                "JSONValue is not an object");
+        return *enforceEx!JSONException(k in store.object,
+                                        "Key not found: " ~ k);
     }
 
     auto opBinaryRight(string op : "in")(string k) const