Fix cartesianProduct: default order should be lexicographically sorted (issue 9878) #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per the discussion in the newsgroup, we should sleep a tad more on this. Thanks for the timely response! |
|
ping @andralex Any new ideas about how to proceed? |
|
Rebased to prevent from going stale. |
|
tbh, I'd rather check this in first than to wait for an unscheduled future improvement. |
|
Rebased to fix conflict |
|
@andralex any progress on this decision? |
|
Merged with new pull that also addresses the exponential template instantiation problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the default order was reverse-lexicographic, because of the order of static if in handling the case where one of the inputs may be infinite. Swapping the order of the static ifs produces the nicer ordering when both ranges are finite.
http://d.puremagic.com/issues/show_bug.cgi?id=9878