Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG2.063] Issue 10268 - std.typecons.Nullable!JSONValue - error instantiating #1340

Merged
merged 1 commit into from Jun 9, 2013

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Jun 9, 2013

http://d.puremagic.com/issues/show_bug.cgi?id=10268

I found that the released qualified constructor feature in 2.063 + inout doesn't work (bug10313), so use a workaround for the bug.

@@ -1187,7 +1187,8 @@ struct Nullable(T)
/**
Constructor initializing $(D this) with $(D value).
*/
this()(T value) inout
//this()(inout T value) inout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? As I already said, next line is workaround. I'd like to keep this "proper" signature until compiler bug will be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Guess an explanatory comment would then be in order :o).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah...OK. I added small comment to explain what's the "workaround".

@andralex
Copy link
Member

andralex commented Jun 9, 2013

Sorry, went to sleep before you replied.

andralex added a commit that referenced this pull request Jun 9, 2013
[REG2.063] Issue 10268 - std.typecons.Nullable!JSONValue - error instantiating
@andralex andralex merged commit e9d5202 into dlang:master Jun 9, 2013
@9rnsr
Copy link
Contributor Author

9rnsr commented Jun 9, 2013

No problem. Thanks!

andralex added a commit that referenced this pull request Jun 9, 2013
[REG2.063] Issue 10268 - std.typecons.Nullable!JSONValue - error instantiating
@9rnsr 9rnsr deleted the fix10268 branch December 2, 2013 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants