Issue 11123 - std.getopt should support function callbacks. #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expected you'd fix this quickly. Looks good. |
|
Someone on IRC asked for it, saying they thought that C-style argument handling was supported (meaning "call this function when an argument is passed"). |
|
It's green, yay. Any objections on pulling this? |
| is(typeof(receiver) == delegate) && | ||
| enum isCallbackWithLessThanTwoParameters = | ||
| (is(typeof(receiver) == delegate) || | ||
| is(typeof(*receiver) == function)) && |
There was a problem hiding this comment.
You can't put both of these on the same line? The line break seems arbitrary to me, especially when both tests constitute a single "conditional block".
| @@ -504,7 +504,8 @@ void handleOption(R)(string option, R receiver, ref string[] args, | |||
| // string receiver | |||
| *receiver = to!(typeof(*receiver))(val); | |||
| } | |||
| else static if (is(typeof(receiver) == delegate)) | |||
| else static if (is(typeof(receiver) == delegate) || | |||
| is(typeof(*receiver) == function)) | |||
There was a problem hiding this comment.
I'd have thought you'd have done this one too...
There was a problem hiding this comment.
I'm trying to make the code consistent, this line will be way too wide compared to the other code that surrounds it.
monarchdodra
added a commit
that referenced
this pull request
Sep 27, 2013
Issue 11123 - std.getopt should support function callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=11123