Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document that parseUUID consumes its input range #1990

Merged
merged 1 commit into from Mar 10, 2014

Conversation

jpf91
Copy link
Contributor

@jpf91 jpf91 commented Mar 10, 2014

fixes https://d.puremagic.com/issues/show_bug.cgi?id=12148

(Although right now I'm not sure if this behavior is useful as parseUUID processes the complete input, unlike the normal parse functions.)

@monarchdodra
Copy link
Collaborator

How about making that a documented unittest? Also, (arguably), I'd prefer s/its input range/its argument/, and s/This parser/Like most parsers/

If you disagree, or don't feel like doing it, do tell me, so I can merge regardless.

@jpf91
Copy link
Contributor Author

jpf91 commented Mar 10, 2014

I adjusted the comment. I'd like to keep the example code after the comment and not in the examples section as it's meant as a clarification of the comment. That's why I didn't use documented unit tests.

monarchdodra added a commit that referenced this pull request Mar 10, 2014
[DOCS] Document that parseUUID consumes its input range
@monarchdodra monarchdodra merged commit 9c5500d into dlang:master Mar 10, 2014
@jpf91 jpf91 deleted the uuidDoc branch March 10, 2014 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants