Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 12394 - Regression: std.regex unittests take agonizingly long ... #2098

Merged
merged 1 commit into from Apr 22, 2014

Conversation

WalterBright
Copy link
Member

...to run - like hours on OSX

@WalterBright
Copy link
Member Author

Fix suggested by Dmitry Olshansky.

@yebblies
Copy link
Member

Auto-merge toggled on

yebblies added a commit that referenced this pull request Apr 22, 2014
fix Issue 12394 - Regression: std.regex unittests take agonizingly long ...
@yebblies yebblies merged commit 6dbc50b into dlang:master Apr 22, 2014
@DmitryOlshansky
Copy link
Member

Ehm. Nothing critical but why not just merge the fix in #2038? Seems like I basically cannot reach you for weeks, what's the best way to nag? :)

@yebblies
Copy link
Member

what's the best way to nag? :)

Experience says complain to Andrei on the forum if you want Walter's attention.

@WalterBright
Copy link
Member Author

@DmitryOlshansky,

  1. Fix issue 12419: assertion failure in std.utf #2038 says nothing about issue 12394.
  2. issue 12394 has no reference to Fix issue 12419: assertion failure in std.utf #2038

meaning I had no clue there was any relationship between the two

  1. I generally delegate phobos issues to Andrei
  2. if you've emailed me about this, I didn't receive it

BTW, thanks for changing your github handle to your name.

@DmitryOlshansky
Copy link
Member

@WalterBright
Pardon issue #2037. I replied to your email. Probably it got lost.
Indeed I didn't link the pull in bugzilla, I can't recall why - maybe because I couldn't test the fix on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants