FIX 12661: [REG2.066a] std.regex with -debug causes linker errors #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove another use of the comma operator
Fix issue 12446 - std.parallelism.amap: prefer iteration to indexing
Undefined format in std.algorithm.max
Test that UTF-8 decoding yields a value in the valid range. UTF-8 may encode values beyond these covered by [0, 0x10FFFF].
Fix issue 12419: assertion failure in std.utf
Fix Issue 12449 - Undefined format in std.algorithm.max
Following typical design in other languages, the function is named uniform01. It can be templated on floating-point type, defaulting to double if none is specified. The implementation is pretty much derived from its counterpart in Boost.Random, in particular in its taking account of the different requirements for integral versus floating-point RNG values, and in checking that the generated variate is less than 1 before returning. This last check is necessary simply because we can't guarantee, in the case of a floating-point based RNG, that we will not get a result exactly equal to 1. Fixes http://d.puremagic.com/issues/show_bug.cgi?id=5240
Fixing 9975 revealed that checking `pointsTo` was creating problems in swap for legitimate use cases. This is because: 1. pointsTo can sometimes create "false positives" 2. Internal pointing is not outright forbidden, it is just that the runtime is allowed to make the assumption they don't exist. While swapping aliasing objects is a sign of stink, it should still "just work".
as well as remove erroneous documentation.
Issue 5228 - Add GetOptException and document exceptions
Fixup for 9975: swap and pointsTo
Improve emplaceRef for qualified construction
Adding extra asserts always helps. As for the enforce, I'm unsure why it was there in the first place: All the other branches simply make the assumption the target is large enough.
Only need to chech u < 1 if RNG returns non-integral variates.
memcpy is not CTFEable, so avoid it for structs without dtor, postblit that can be assigned with plain =. This leaves as is (compile error in CTFE) structs that contain immutable/const memebers the fact that moves overwrites such fields is questionable to begin with.
Fix newly introduced FQN issue caused by 313
Make move CTFEable for simple structs and classes
Split the overly long sentence in two, otherwise it's easy to miss the point about auto-generation.
Clarify DDocs of hasElaborateAssign
Fixed all spelling errors of "Params" from "Parems"
It's no longer necessary and hasn't been for some time (it was to deal with the fact that dmd ran out of memory on Windows when compiling std.datetime's unit tests, which hasn't been a problem for a while). So, we're removing it.
|
What's going on with the commit list in this pull? |
|
Wooow!! I didn't noticed that it mirrors after I have sent. Let me fix this again, please. |
|
Umm...got worse and worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=12661
I have no idea what is the actual problem of regression.
This pull is a minimum workaround which removes an inference mismatch from std.range.SortedRange.