Fix issue 3363: std.stream.readf segfaults with immutable format strings #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hackerpilot
changed the title
|
Unit test? Otherwise, I'm going to say LGTM, because it seems ok as a change, and nobody uses |
| @@ -703,7 +703,7 @@ class Stream : InputStream, OutputStream { | |||
| } | |||
| if (fmt.length == 0 || i == fmt.length) { | |||
| i = 0; | |||
| if (arguments[j] is typeid(char[])) { | |||
| if (arguments[j] is typeid(string) || arguments[j] is typeid(char[])) { | |||
|
LGTM |
|
+1 to addition of the unit test |
|
Yes, please add unittest, then this looks ready to merge. |
|
Unit test added. |
|
LGTM. |
|
Auto-merge toggled on |
mihails-strasuns
pushed a commit
that referenced
this pull request
Jul 11, 2014
Fix issue 3363: std.stream.readf segfaults with immutable format strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=3363