Fix Issue #12877: allow uniform() to handle dchar variates #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [dchar.min, dchar.max] does not cover the full bit range of dchar,
optimizations that work for other integral types will fail here, and
result in illegal unicode points being generated.
This fix avoids breaking any existing calls to uniform() via a twofold
approach:
* uniform!"[]"(T.min, T.max) will only call uniform!ResultType if
T is not a dchar;
* uniform!dchar will not try and use the entire bit range but will
instead call uniform!"[]"(dchar.min, dchar.max).
Unittests have been added that should prevent such issues from arising
again.
monarchdodra
added a commit
that referenced
this pull request
Jun 10, 2014
Fix Issue #12877: allow uniform() to handle dchar variates
|
Awesome, thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
[dchar.min, dchar.max]does not cover the full bit range ofdchar, optimizations that work for other integral types will fail here, and result in illegal unicode points being generated.This fix avoids breaking any existing calls to
uniform()via a twofold approach:uniform!"[]"(T.min, T.max)will only calluniform!ResultTypeifTis not adchar;uniform!dcharwill not try and use the entire bit range but will instead calluniform!"[]"(dchar.min, dchar.max).Unittests have been added that should prevent such issues from arising again.