fix Issue 13171 - std.algorithm.until(range, sentinel, OpenRight.no) doe...

[NilsBossung]

...sn't propagate popping of sentinel to range

https://issues.dlang.org/show_bug.cgi?id=13171

[DmitryOlshansky]

LGTM

[quickfur]

LGTM. I'm not sure about using bit ops to manipulate booleans, but in this case the alternative is significantly more verbose so I'll leave it at that.

[schuetzm]

It could use ||= instead of |=, however.

[quickfur]

There's no such operator as ||=. (Perhaps there should be? :P Good luck convincing Walter, though!)

[NilsBossung]

On Monday 21 July 2014 12:04:13 H. S. Teoh wrote:

There's no such operator as ||=. (Perhaps there should be? :P Good luck
convincing Walter, though!)

I did type ||= at first.

I see one potential issue with |=: it's eager. The right side is always
evaluated, even when the left side is true already. I don't think that's a
problem here.

But if anyone would like to see _done = _done || _input.empty or some other
variant, say so and your wish shall be granted.

[schuetzm]

@quickfur Wow, I was really convinced it exists. Should have checked first...
@NilsBossung Right, it will probably compile down to exactly the same machine code, no matter what you use.

[mihails-strasuns]

But if anyone would like to see _done = _done || _input.empty or some other
variant, say so and your wish shall be granted.

Please do. It is not that longer but will prevent inevitable "why bitops?" question from readers.

[NilsBossung]

done

[mihails-strasuns]

thanks!

[mihails-strasuns]

Auto-merge toggled on