Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reg] 2nd try fix Issue 13241 - writeln no longer flushes stdout #2442

Closed
wants to merge 1 commit into from

Conversation

WalterBright
Copy link
Member

This is the fix I believe is better.

fix https://issues.dlang.org/show_bug.cgi?id=13241

See also #2396

@CyberShadow
Copy link
Member

Why is this patch necessary? It doesn't fix anything, it just worsens performance by adding an additional fflush call.

@quickfur
Copy link
Member

I don't understand what this PR is supposed to fix. I thought we've already established that calling fputc will flush correctly upon newline (presumably it calls fflush somewhere in its C library implementation), and we already have to call fputc anyway. All this PR does is just to add yet another call to flush. Why?

@WalterBright
Copy link
Member Author

Ack, looks like I got turned around with "\n" versus '\n'.

Never mind!

@WalterBright WalterBright deleted the fix13241 branch August 20, 2014 00:24
@mihails-strasuns
Copy link

So, will you revert the revert? :)

@CyberShadow
Copy link
Member

Well, it was never merged, so we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants